Linmodems Mailing list Archives

Google
 
Web archives.linmodems.org

Return-Path: <robert.thornburrow@tsac.fsnet.co.uk>
Mailing-List: contact discuss-help@linmodems.org; run by ezmlm
Delivered-To: mailing list discuss@linmodems.org
Received: (qmail 12440 invoked from network); 17 Apr 2004 09:11:36 -0000
Received: from heisenberg.zen.co.uk (212.23.3.141)
  by www.linmodems.org with SMTP; 17 Apr 2004 09:11:36 -0000
Received: from [82.69.26.118] (helo=tsac.fsnet.co.uk)
	by heisenberg.zen.co.uk with esmtp (Exim 4.30)
	id 1BElrI-0003VN-1T; Sat, 17 Apr 2004 09:11:32 +0000
Message-ID: <4080F75C.6000505@tsac.fsnet.co.uk>
Date: Sat, 17 Apr 2004 10:22:36 +0100
From: Robert Thornburrow <robert.thornburrow@tsac.fsnet.co.uk>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031031
X-Accept-Language: en-gb, en-us, en
MIME-Version: 1.0
To: Jamie Lokier <jamie@softmodem.org>
CC: "Omar A. S. Guerrero" <osgcon@yahoo.com.mx>,  discuss@linmodems.org
Subject: Re: A problem compiling the driver...
References: <20040414205115.63047.qmail@web13125.mail.yahoo.com> <407DACA9.7040800@tsac.fsnet.co.uk> <407FE435.8020303@tsac.fsnet.co.uk> <20040416185147.GB25402@mail.shareable.org>
In-Reply-To: <20040416185147.GB25402@mail.shareable.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-Heisenberg-IP: [82.69.26.118]

Hi Jamie,

Many thanks for that - this is getting to my limit of the kernel sources
(particularly as none of the Kernel trees I am using use atomic_t for
the count field of the tty struct!).

I don't suppose you know if there is a #define that indicates that
atomic_t is in use?  I am guessing that this is a RedHat thing, and that
it is to do with the updated threading code that they shipped in RH9.0
(which I do have, but not to hand).  I am guessing that the patches for
this are still being applied to Fedora, in which case anyone using any
RedHat release from 9.0 onwards, or any Fedora release will have this
problem.

If I can get a definitive answer on this, then I can see if I can get
the changes incorporated into the next pctel driver release.

Best regards,

     Robert

Jamie Lokier wrote:
> Robert Thornburrow wrote:
> 
>>In the meantime, if you change the offending line to read:
>>
>>    if ((tty->count.counter == 1) && (state->count != 1))
>>
>>instead of:
>>
>>    if ((tty->count == 1) && (state->count != 1))
> 
> 
> The correct line is:
> 
> 	if (atomic_read(&tty->count) == 1 && state->count != 1) {
> 
> -- Jamie
> 


Webmaster: Russell Nelson
Last modified: Wed Jul 30 11:02:43 EDT 2003