Linmodems Mailing list Archives

Google
 
Web archives.linmodems.org

Return-Path: <robert.thornburrow@tsac.fsnet.co.uk>
Mailing-List: contact discuss-help@linmodems.org; run by ezmlm
Delivered-To: mailing list discuss@linmodems.org
Received: (qmail 11465 invoked from network); 19 Apr 2004 14:41:55 -0000
Received: from pythagoras.zen.co.uk (212.23.3.140)
  by www.linmodems.org with SMTP; 19 Apr 2004 14:41:55 -0000
Received: from [82.69.26.118] (helo=tsac.fsnet.co.uk)
	by pythagoras.zen.co.uk with esmtp (Exim 4.30)
	id 1BFZy2-0007Rr-7K; Mon, 19 Apr 2004 14:41:50 +0000
Message-ID: <4083E7C9.6020208@tsac.fsnet.co.uk>
Date: Mon, 19 Apr 2004 15:52:57 +0100
From: Robert Thornburrow <robert.thornburrow@tsac.fsnet.co.uk>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031031
X-Accept-Language: en-gb, en-us, en
MIME-Version: 1.0
To: "Omar A. S. Guerrero" <osgcon@yahoo.com.mx>
CC: LinModems <discuss@linmodems.org>
Subject: Fedora compile error... was Re: A problem compiling the driver...
References: <20040418195131.9798.qmail@web13124.mail.yahoo.com>
In-Reply-To: <20040418195131.9798.qmail@web13124.mail.yahoo.com>
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-Pythagoras-IP: [82.69.26.118]

Hi Omar,

There has been much debate about this on the linmodems list of
late - the problem is specific to Fedora Core releases using
the pre-built kernel.  The problem applies to most Open or Part-
Open Source Linux drivers for soft modems.

We are working on a patch to the pctel driver, but as yet have
not come up with a reliable way to detect kernels which have
tty->count defined as an atomic_t.  The correct code for Fedora
is (I believe):

   if ((atomic_read(&tty->count) == 1) && (state->count != 1)) {

[thanks to Jamie Lokier for that].

Best regards,

     Robert

Omar A. S. Guerrero wrote:
> Hi Robert:
> 
> I finally arrived to the answer!
> 
> The problem is effectively in the line [2815] on file
> ptserial-2.4.7,c .
> I solved the problem modifying the line 
> if ((tty->count == 1) && (state->count != 1))
> by
> if (((tty->count).counter == 1) && (state->count !=
> 1)) {
> because tty->count isn't a 'int' but is a 'atomic_t'
> structure. Please see the files .../linux/tty.h at the
> declaration of tty_struct structure; and atomic.h for
> the atomic_t structure declaration. Both for
> reference.
> 
> Well I compiled the modified source with the
> ./configure -> make -> make install steps and
> everithing is O.K. Now when I executed the isnmod
> pctel and ptserial step, I got the error:
> 
> lib/modules/2.4.22-1.2115.npt1/misc/pctel.o) is
> compiled with a gcc version 2 compiler, while the
> kernel you are running is compiled with a gcc version
> 3 compiler. This is known to not work
> 
> which I addressed using the pctel mini-How-To page.
> Now I am at my home computer with linux running the
> driver.
> 
> Thanks a lot for your attention at my request.
> greetings
> Omar.
> 
> _________________________________________________________
> Do You Yahoo!?
> La mejor conexión a internet y 25MB extra a tu correo por $100 al mes. http://net.yahoo.com.mx
> 


Webmaster: Russell Nelson
Last modified: Wed Jul 30 11:02:43 EDT 2003