Linmodems Mailing list Archives

Google
 
Web archives.linmodems.org

Return-Path: <w.murray@rl.ac.uk>
Mailing-List: contact discuss-help@linmodems.org; run by ezmlm
Delivered-To: mailing list discuss@linmodems.org
Received: (qmail 27018 invoked from network); 19 Apr 2004 17:09:44 -0000
Received: from balin.rl.ac.uk (130.246.135.155)
  by www.linmodems.org with SMTP; 19 Apr 2004 17:09:44 -0000
X-RAL-MFrom: <w.murray@rl.ac.uk>
X-RAL-Connect: <wjmurray.pp.rl.ac.uk [130.246.42.113]>
Received: from localhost.localdomain (wjmurray.pp.rl.ac.uk [130.246.42.113])
	by balin.rl.ac.uk (8.12.8/8.12.8) with ESMTP id i3JH9lvN009650;
	Mon, 19 Apr 2004 18:09:50 +0100
Received: from localhost.localdomain (wjmurray [127.0.0.1])
	by localhost.localdomain (8.12.10/8.12.10) with ESMTP id i3JFKrbp008167;
	Mon, 19 Apr 2004 16:20:53 +0100
Received: (from murray@localhost)
	by localhost.localdomain (8.12.10/8.12.8/Submit) id i3JFKrMs008165;
	Mon, 19 Apr 2004 16:20:53 +0100
X-Authentication-Warning: localhost.localdomain: murray set sender to w.murray@rl.ac.uk using -f
Subject: Re: Fedora compile error... was Re: A problem compiling the
	driver...
From: William John Murray <w.murray@rl.ac.uk>
To: Robert Thornburrow <robert.thornburrow@tsac.fsnet.co.uk>
Cc: linmodems <discuss@linmodems.org>
In-Reply-To: <4083E7C9.6020208@tsac.fsnet.co.uk>
References: <20040418195131.9798.qmail@web13124.mail.yahoo.com>
	 <4083E7C9.6020208@tsac.fsnet.co.uk>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Organization: CCLRC
Message-Id: <1082388052.8085.20.camel@wjmurray>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-7) 
Date: Mon, 19 Apr 2004 16:20:53 +0100
X-Scanned-By: MIMEDefang 2.39

   Hi Robert,
            I agree, a correct patch is required. But a kludge
can help? For pctel 0.9.6.2 I added

FEDORA =3D `find /etc -maxdepth 1 -name fedora-release | wc -l`

and then passed the FEDORA variable to ptserial-2.4.7.c
with a -D FEDORA=3D$(FEDORA)
and finally used
#if (FEDORA>0)
to decide how to make this test.
   There has only been 1 complaint from someone with their own
kernel on a Fedora machine....

    Bill

On Mon, 2004-04-19 at 15:52, Robert Thornburrow wrote:
> Hi Omar,
>=20
> There has been much debate about this on the linmodems list of
> late - the problem is specific to Fedora Core releases using
> the pre-built kernel.  The problem applies to most Open or Part-
> Open Source Linux drivers for soft modems.
>=20
> We are working on a patch to the pctel driver, but as yet have
> not come up with a reliable way to detect kernels which have
> tty->count defined as an atomic_t.  The correct code for Fedora
> is (I believe):
>=20
>    if ((atomic_read(&tty->count) =3D=3D 1) && (state->count !=3D 1)) {
>=20
> [thanks to Jamie Lokier for that].
>=20
> Best regards,
>=20
>      Robert
>=20
> Omar A. S. Guerrero wrote:
> > Hi Robert:
> >=20
> > I finally arrived to the answer!
> >=20
> > The problem is effectively in the line [2815] on file
> > ptserial-2.4.7,c .
> > I solved the problem modifying the line=20
> > if ((tty->count =3D=3D 1) && (state->count !=3D 1))
> > by
> > if (((tty->count).counter =3D=3D 1) && (state->count !=3D
> > 1)) {
> > because tty->count isn't a 'int' but is a 'atomic_t'
> > structure. Please see the files .../linux/tty.h at the
> > declaration of tty_struct structure; and atomic.h for
> > the atomic_t structure declaration. Both for
> > reference.
> >=20
> > Well I compiled the modified source with the
> > ./configure -> make -> make install steps and
> > everithing is O.K. Now when I executed the isnmod
> > pctel and ptserial step, I got the error:
> >=20
> > lib/modules/2.4.22-1.2115.npt1/misc/pctel.o) is
> > compiled with a gcc version 2 compiler, while the
> > kernel you are running is compiled with a gcc version
> > 3 compiler. This is known to not work
> >=20
> > which I addressed using the pctel mini-How-To page.
> > Now I am at my home computer with linux running the
> > driver.
> >=20
> > Thanks a lot for your attention at my request.
> > greetings
> > Omar.
> >=20
> > _________________________________________________________
> > Do You Yahoo!?
> > La mejor conexi=F3n a internet y 25MB extra a tu correo por $100 al mes=
. http://net.yahoo.com.mx
> >=20
>=20

Webmaster: Russell Nelson
Last modified: Wed Jul 30 11:02:43 EDT 2003