Linmodems Mailing list Archives

Google
 
Web archives.linmodems.org

Return-Path: <robert.thornburrow@tsac.fsnet.co.uk>
Mailing-List: contact discuss-help@linmodems.org; run by ezmlm
Delivered-To: mailing list discuss@linmodems.org
Received: (qmail 29803 invoked from network); 21 Apr 2004 09:27:54 -0000
Received: from heisenberg.zen.co.uk (212.23.3.141)
  by www.linmodems.org with SMTP; 21 Apr 2004 09:27:54 -0000
Received: from [82.69.26.118] (helo=tsac.fsnet.co.uk)
	by heisenberg.zen.co.uk with esmtp (Exim 4.30)
	id 1BGDUY-00081j-IL; Wed, 21 Apr 2004 08:54:02 +0000
Message-ID: <4086394F.7060202@tsac.fsnet.co.uk>
Date: Wed, 21 Apr 2004 10:05:19 +0100
From: Robert Thornburrow <robert.thornburrow@tsac.fsnet.co.uk>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031031
X-Accept-Language: en-gb, en-us, en
MIME-Version: 1.0
To: Jamie Lokier <jamie@softmodem.org>
CC: linmodems <discuss@linmodems.org>
Subject: Re: Fedora compile error... was Re: A problem compiling the	driver...
References: <20040418195131.9798.qmail@web13124.mail.yahoo.com> <4083E7C9.6020208@tsac.fsnet.co.uk> <1082388052.8085.20.camel@wjmurray> <40841AC0.1090806@tsac.fsnet.co.uk> <20040421015159.GB23621@mail.shareable.org>
In-Reply-To: <20040421015159.GB23621@mail.shareable.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-Heisenberg-IP: [82.69.26.118]

Hi Jamie,

I already did it!  The updated version of my testing versions of the pctel
driver should appear on the pctel page of http://linmodems.technion.ac.il
just as soon as Jacques gets some time to update the site.

The test was to compile a line containing "atomic_read(&tty->conunt)".  If
this works, then we know for certain that the type of "count" is "atomic_t".
I have then defined HAVE_TTY_COUNT_ATOMIC to control which bits of code
get compiled (ethier the ones that use atomic_read() or the ones that don't.
I chose to do it this way, as there may be other types for count in the
future, and atomic_t is one definite thing we can check for.  Checking that
the type is an "int" doesn't guarantee that the type is "atomic_t".

Now all I need is a tester - I've mocked up the code as I beleive it appears
and the atomic_t is detected, but there's nothing like the real thing!

I have also forwarded my changes to Jan Stifter (the official owner of the
pctel driver project), so hopefully they will make their way into an official
release sometime soon.

Best regards,

      Robert

> Robert Thornburrow wrote:
> 
>>I will have a crack at writing this, but as I don't have Fedora,
>>I can't exactly test it properly.  Maybe someone with Fedora will
>>test my script fragment for me, as it looks like it could be of
>>benefit to a lot of driver maintainers.
> 
> 
> There's a small test for this exact thing in Alsa, presumably for midi
> support which is a kind of serial port.
> 
> You could copy the Autoconf code from Alsa.
> 
> -- Jamie
> 


Webmaster: Russell Nelson
Last modified: Wed Jul 30 11:02:43 EDT 2003